Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/christenjack/auth #39

Merged
merged 36 commits into from
Jun 1, 2024
Merged

Feature/christenjack/auth #39

merged 36 commits into from
Jun 1, 2024

Conversation

christen03
Copy link
Contributor

Tracking Info

#35

Changes

Added Firestore for auth, login fields, and the UI for logins

Testing

Tested login at the route "/admin"

Confirmation of Change

Test login at localhost:3000/admin
username: 4flotdev2@gmail.com
password: 4flotdevelopment

@christen03 christen03 requested a review from jennymar as a code owner May 9, 2024 00:25
@jennymar jennymar requested a review from kevindo0720 May 9, 2024 20:37
Copy link
Collaborator

@jennymar jennymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added email validation to forget password page and did minor frontend fixes. Amazing job integrating with Firebase and making the redirection hooks! Also, thanks for clean code and file organization!

Copy link
Contributor

@kevindo0720 kevindo0720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CSS styling (color/fonts) does not match entirely with the Figma, but besides that, everything else is perfect!

@jennymar jennymar merged commit 2b4d1c4 into main Jun 1, 2024
2 checks passed
@jennymar jennymar deleted the feature/christenjack/auth branch June 1, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants