Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish project #48

Merged
merged 7 commits into from
Jun 30, 2024
Merged

Finish project #48

merged 7 commits into from
Jun 30, 2024

Conversation

benjaminJohnson2204
Copy link
Contributor

Tracking Info

N/A

Changes

  • Added character limit to newsletter title & description in admin editor
  • Added logic to enforce character limit on text fields on frontend
  • Added image upload to event creator in admin portal
  • Removed console logging and commented-out code
  • Rebuilt backend (to update backend/dist directory)

Testing

  • Tried to save changes with a field over the character limit to ensure an error is shown + it can't be saved
  • Testing adding & deleting images for event creator, and making sure changes are reflected on events page

Confirmation of Change

@vercel Vercel
Copy link

vercel bot commented Jun 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4flot-website-revamp ❌ Failed (Inspect) Jun 30, 2024 11:30pm

@jennymar jennymar merged commit cca3f98 into main Jun 30, 2024
3 of 4 checks passed
@jennymar jennymar deleted the feature/benjaminJohnson2204/finish-project branch June 30, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennymar jennymar Awaiting requested review from jennymar jennymar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminJohnson2204 @jennymar