Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal Solution Component #24

Merged
merged 15 commits into from
Feb 10, 2025
Merged

Proposal Solution Component #24

merged 15 commits into from
Feb 10, 2025

Conversation

b-jonathan
Copy link
Contributor

Tracking Info

Resolves #16

Changes

Added Solution Component

  • Statement component
  • Investment component
  • Appointment component
  • AccessibleClinics component
  • AffordableSurgeries component

Testing

We used a full front-to-back testing, since it was only a frontend design, all we did was test it for responsiveness for sizes above 1440px which is what was required from the current design.

image image image image image

@b-jonathan b-jonathan requested a review from soma-p as a code owner February 3, 2025 06:57
@b-jonathan b-jonathan linked an issue Feb 3, 2025 that may be closed by this pull request
b-jonathan and others added 6 commits February 4, 2025 23:27
Finished statement, investment and appointment page.

Added Montserrat font into globals.css

Added chartjs library for bar graph
Affordable Surgeries and Accessible Clinics completed, may need some touch ups.
Put Solution component into home page
@b-jonathan b-jonathan force-pushed the 16-proposal-solution-component branch from 1689681 to 3298b5f Compare February 5, 2025 07:29
@b-jonathan b-jonathan marked this pull request as draft February 5, 2025 08:22
@b-jonathan b-jonathan marked this pull request as ready for review February 5, 2025 08:27
@soma-p soma-p requested review from syz16, Argsweet and Syu125 and removed request for syz16 February 6, 2025 03:11
@Syu125
Copy link
Contributor

Syu125 commented Feb 6, 2025

I noticed that when the percentage goes down, the width changes, causing the right text ("Small Investment, Major Impact" part) to shift back and forth. Not sure if this is a big issue, but I think maybe the left percentage text a fixed width might help stabilize it.

@Syu125
Copy link
Contributor

Syu125 commented Feb 6, 2025

Typo here: "Accessible"
image

Copy link
Contributor

@Syu125 Syu125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments in the thread (regarding the "small investment, major impact" and "accessible clinics"). These are minor things, so once addressed this should be good to merge. Good job!

@b-jonathan b-jonathan marked this pull request as draft February 6, 2025 04:36
@b-jonathan b-jonathan marked this pull request as ready for review February 6, 2025 05:01
@b-jonathan b-jonathan requested a review from Syu125 February 6, 2025 05:01
Copy link
Contributor

@Syu125 Syu125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw that the fixes are done - everything looks good now!

@Argsweet Argsweet closed this Feb 9, 2025
@Argsweet Argsweet reopened this Feb 9, 2025
Copy link
Contributor

@Argsweet Argsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! I would like to point out the typo in the filename "AccesibleClinics.tsx", however this doesnt affect the page itself (not sure if this was resolved with the earlier comments). Looks good!

Copy link
Collaborator

@soma-p soma-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great you guys! Good job :)

@soma-p soma-p merged commit 79a2ee2 into main Feb 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal / Solution Component
5 participants