-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal Solution Component #24
Conversation
Finished statement, investment and appointment page. Added Montserrat font into globals.css Added chartjs library for bar graph
Affordable Surgeries and Accessible Clinics completed, may need some touch ups.
Put Solution component into home page
1689681
to
3298b5f
Compare
Changed a few file names and fixed linter errors
I noticed that when the percentage goes down, the width changes, causing the right text ("Small Investment, Major Impact" part) to shift back and forth. Not sure if this is a big issue, but I think maybe the left percentage text a fixed width might help stabilize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments in the thread (regarding the "small investment, major impact" and "accessible clinics"). These are minor things, so once addressed this should be good to merge. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw that the fixes are done - everything looks good now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! I would like to point out the typo in the filename "AccesibleClinics.tsx", however this doesnt affect the page itself (not sure if this was resolved with the earlier comments). Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great you guys! Good job :)
Tracking Info
Resolves #16
Changes
Added Solution Component
Testing
We used a full front-to-back testing, since it was only a frontend design, all we did was test it for responsiveness for sizes above 1440px which is what was required from the current design.