Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document View #25

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Document View #25

wants to merge 9 commits into from

Conversation

Azhou2023
Copy link
Contributor

Tracking Info

Resolves #13

Changes

Added document view page. Features:

  • Adding, editing and deleting comments
  • Changing document name inside document view
  • Printing & downloading document pdf
  • Document preview in veteran table

Testing

Tested all backend routes in Postman and with the frontend, tested different ways to add/edit/delete comments were all consistent. Tested that all file creation logic resulted in the correct flow.

Confirmation of Change

Screenshot 2025-03-03 at 9 50 17 PM Screenshot 2025-03-03 at 9 50 42 PM Screenshot 2025-03-03 at 9 50 31 PM

@Azhou2023 Azhou2023 requested a review from Anthonyp0329 as a code owner March 4, 2025 06:09
@Anthonyp0329 Anthonyp0329 requested review from jliu0140 and emmaz12 March 5, 2025 23:21
Copy link
Collaborator

@Anthonyp0329 Anthonyp0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome Andrew! Just one small refactoring change, where the veteranDashboard should be able to fetch veteran name + pass id, using the veteran id, to the FileUpload.tsx component

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to as part of this pr, refactor this page to based on the veteran's id, fetch the veteran and display the correct name, and also pass this id into fileupload.tsx?

@Azhou2023 Azhou2023 requested a review from Anthonyp0329 March 9, 2025 08:10
Copy link
Collaborator

@Anthonyp0329 Anthonyp0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just make sure to resolve conflicts with main and re-test to ensure everything is working well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Viewing/ Commenting
2 participants