-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document View #25
base: main
Are you sure you want to change the base?
Document View #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome Andrew! Just one small refactoring change, where the veteranDashboard should be able to fetch veteran name + pass id, using the veteran id, to the FileUpload.tsx component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to as part of this pr, refactor this page to based on the veteran's id, fetch the veteran and display the correct name, and also pass this id into fileupload.tsx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just make sure to resolve conflicts with main and re-test to ensure everything is working well
Tracking Info
Resolves #13
Changes
Added document view page. Features:
Testing
Tested all backend routes in Postman and with the frontend, tested different ways to add/edit/delete comments were all consistent. Tested that all file creation logic resulted in the correct flow.
Confirmation of Change