TL-1007. add custome logger #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobrabd
reviewed
Mar 5, 2020
trood/contrib/mylogger.py
Outdated
| elif action == 'delete': | ||
| return '3003' | ||
|
|
||
| def process(self, msg, kwargs): |
Contributor
There was a problem hiding this comment.
Не смотря на то, что мы ожидаем получить все поля, что то может пойти не так, тут могут вылезти KeyError, IndexError
Я бы предложил продумать как их обходить или как их обрабатывать
orn0t
reviewed
Mar 5, 2020
Collaborator
|
Логгер - переиспользуемый компонент, в нем не должно быть захардкожено номера ошибок и сообщений а только механизм валидации/форматирования. Основные задачи логера - Заставлять разработчика форматировать ошибки одинаковым образом. поэтому должен присутствовать какойто аспект валидации.. типа нельзя вызвать логер если не добавил описание ошибки в определенную структуру (например errors.py в приложении). а все |
sobrabd
requested changes
Mar 10, 2020
zapouria
force-pushed
the
TL-1007
branch
2 times, most recently
from
4bce05e to
5f45774
Compare
apply new commits
orn0t
force-pushed
the
dev
branch
2 times, most recently
from
022641c to
5622594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.