feat: implement graceful shutdown and refactor command registration #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pixel365
commented
Mar 12, 2025
pixel365
commented
- Added graceful shutdown in main using signal.NotifyContext for proper termination.
- Passed context to the root command through ExecuteContext.
- Moved subcommand registration into the public root command, replacing init-based setup for improved readability and maintainability.
- Added graceful shutdown in main using signal.NotifyContext for proper termination. - Passed context to the root command through ExecuteContext. - Moved subcommand registration into the public root command, replacing init-based setup for improved readability and maintainability. Signed-off-by: Ruslan Semagin <pixel.365.24@gmail.com>
szverev
approved these changes
Mar 13, 2025
Contributor
|
Hello @pixel365, Thank you for your contribution. We appreciate your efforts. I have approved and merged this PR. If you are interested in further developing the Trood CLI, we can discuss it on our Discord server or here, opening a GitHub Discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.