Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SysOperationFramework generation #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FabioBot-sys
Copy link

Hi,
I implemented template generation for SysOperation Framework.
As requested on issue #12.

@TrudAX
Copy link
Owner

TrudAX commented Aug 10, 2023

Wow, thanks a lot.
One big issue, can you implement a Preview button(like in RunBaseBuilder)?
The idea is that a developer should view what will be created without creating objects. Your form has a lot of parameters, and without additional knowledge, it is not clear what will be created, how the naming will be used, what methods will be created etc..
Just add another big Text box and a preview button

Also dialog form with many parameters - it looks great, but from the practical point of view, it is quite hard to use, you can't just save or restore previous parameters. More practical - just use one big text box, and you can save and restore the required parameters. But as you already did that, it is probably fine. But the Preview button should be added(Let me know if you need any help with that)

image

@FabioBot-sys
Copy link
Author

The problem with preview functionality is that one or more classes must be created, and showing them in a single text field may be misleading.
Many of the form parameters are optional.
I can put an asterisk in the mandatory ones to help compile.

I can work on saving previous parameters.

@TrudAX
Copy link
Owner

TrudAX commented Aug 10, 2023

It will not be misleading. Check for example DataContractBuilder, it creates 3 classes and a developer can validate the code visually before creating classes and fix any generated parameters if the result is not as expected(or "play" with parameters). Also a typical dev use case - do not create a new class, but just modify the existing one. If you add a preview it can be easily done. Thanks for the cooperation

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants