WIP: 🚀 Add RewardsFlywheel to ManagedPortfolio #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow rewards to be distributed to depositors on-the-fly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rewards to be distributed to depositors on-the-fly.
The ideal setup for this is to create a rewards treasury that holds TRU, have this treasury increase the allowance for whichever portfolio that'll have rewards, then for the manager of the portfolio to call
setDepositRewards(TRU_ADDRESS, TREASURY_ADDRESS, REWARDS_RATE)where REWARDS_RATE equals the number of TRU (in wei) to be distributed per block to depositors.Depositors can then call
claimRewards()at any time to collect their accrued TRU rewards.Requesting comments before test cases are written. Specific questions:
🚀