Skip to content

Feature/frontend mvp p0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
delfinacorr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/frontend mvp p0 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6118997
fix: agregar basename para corregir error 404 en deploy
delfinacorr Dec 31, 2025
fc5308e
feat: add 404.html for SPA routing and fix router basename
delfinacorr Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/frontend/public/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>frontend</title>
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>
16 changes: 10 additions & 6 deletions packages/frontend/src/app/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import { createBrowserRouter, Navigate } from "react-router-dom";
import LoginPage from "../pages/auth/LoginPage";
import RegisterPage from "../pages/auth/RegisterPage"; // 👈 Importación corregida
import RegisterPage from "../pages/auth/RegisterPage";
import DashboardApp from "../pages/dashboard/DashboardPage";

// 1. Corregimos la navegación para que use rutas relativas
const genericNavigate = (page: string) => {
if (page === 'login') window.location.href = '/login';
if (page === 'register') window.location.href = '/register';
if (page === 'dashboard') window.location.href = '/dashboard';
if (page === 'login') window.location.href = './login';
if (page === 'register') window.location.href = './register';
if (page === 'dashboard') window.location.href = './dashboard';
};

export const router = createBrowserRouter([
Expand All @@ -16,11 +17,14 @@ export const router = createBrowserRouter([
element: <LoginPage onNavigate={genericNavigate} />,
},
{
path: "/register", // 👈 Esta es la ruta para tu nuevo código
path: "/register",
element: <RegisterPage onNavigate={genericNavigate} />,
},
{
path: "/dashboard",
element: <DashboardApp />,
},
]);
], {
// 2. AÑADIMOS ESTO PARA GITHUB PAGES
basename: "/Web3",
});