upgrade: deprecated if_delegate_has_method #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,7 +132,7 @@ def fit(self, X, y, sample_weight=None, **fit_params): | |||
| **fit_params) | |||
| return self | |||
|
|
|||
| @if_delegate_has_method('postprocessor_') | |||
| @available_if('postprocessor_') | |||
There was a problem hiding this comment.
Do we need to make any changes in the unit test?
| @@ -175,7 +175,7 @@ def predict_proba(self, X): | |||
| y_score = pd.DataFrame(y_score, index=X.index).squeeze('columns') | |||
| return self.postprocessor_.predict_proba(y_score) | |||
|
|
|||
| @if_delegate_has_method('postprocessor_') | |||
| @available_if('postprocessor_') | |||
There was a problem hiding this comment.
How do we test if this is working? Have we ran the code end to end to check if this is working?
mnagired
approved these changes
Sep 27, 2023
mnagired
requested changes
Sep 27, 2023
There was a problem hiding this comment.
actually, looks like all of the post-processing tests are failing with the same error:
TypeError: 'str' object is not callable
For example: FAILED tests/sklearn/test_reject_option_classification.py::test_rej_opt_clf_scoring[race-statistical_parity] - TypeError: 'str' object is not callable
Could you please look into this?
|
closing in favor of #511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #475