Update data_preproc_functions.py to solve conversion to float issue #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solving issue 497 when converting values to float due to deprecation of float function in numpy. Trusted-AI#497 (comment) Using pandas built in functions to optimize time. Proof: timeit.timeit("df['age'].apply(lambda x: float(x >= 26))", number=10, setup="import pandas as pd;df = pd.DataFrame({'age':range(1000000)})") >>> 2.8678155599627644 timeit.timeit("(df['age'] >= 26).astype(float)", number=10, setup="import pandas as pd;df = pd.DataFrame({'age':range(1000000)})") >>> 0.01317960600135848 ((df['age'] >= 26).astype(float) == df['age'].apply(lambda x: float(x >= 26))).all() >>> True Signed-off-by: Andrea Baraldi <baraldian@gmail.com>
hoffmansc
reviewed
Oct 11, 2023
aif360/algorithms/preprocessing/optim_preproc_helpers/data_preproc_functions.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
|
Thank you for the fix. @hoffmansc, can a new release be made soon since it is causing issues on Numpy from 1.24? It is causing conflicts with some packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue 497 when converting values to float due to deprecation of float function in numpy.
#497 (comment)
Using pandas built in functions to optimize time.
Proof: