Test fixes #37
Merged
Test fixes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd uneccesary code, solving mult issues
11 tasks
|
Caution Review failedThe pull request is closed. WalkthroughExtensive test suites were added (edge cases, integration, performance, unit). Configuration system was overhauled: multiple domain configs removed/renamed/consolidated; migration and backward-compatibility modules removed; infrastructure access updated. Utilities refactored for validation, math, rotation, and processing. Minor analyzer edits and comments removed. .gitignore updated. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Caller
participant U as utils.common
participant V as validation_utils.EnhancedErrorHandler
C->>U: validate_landmarks(data)
activate U
U->>V: EnhancedErrorHandler(context="MetricValidator")
U->>V: validate_landmarks(data)
V-->>U: ValidationResult{is_valid, errors}
U-->>C: bool (is_valid)
deactivate U
note over U,V: New centralized validation path replaces inline checks
sequenceDiagram
autonumber
participant P as processing_utils
participant R as rotation_utils
participant M as math_utils
P->>R: apply_rotation_to_frame(frame, angle)
activate R
R->>M: degrees_to_radians(angle)
M-->>R: radians
R->>M: apply_rotation_matrix(points, angle)
M-->>R: rotated points
R-->>P: rotated frame
deactivate R
note over P,R: rotate_frame now delegates to RotationUtils (no per-angle branching)
sequenceDiagram
autonumber
participant RD as rotation_detector
participant MP as mediapipe (optional)
RD->>RD: try import mediapipe
alt MediaPipe available
RD->>MP: init pose
RD->>RD: validate_rotation(content)
RD-->>RD: run pose-based checks
else
RD-->>RD: short-circuit defaults (valid=True)
end
note over RD: Fallback behavior when MediaPipe missing
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (45)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests
Chores