-
-
Notifications
You must be signed in to change notification settings - Fork 84
Created email editor component #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughIntroduces a new KoenigEmailEditor React component (wraps KoenigComposableEditor with specific config and plugins) and adds it to the package public API. DemoApp.jsx now uses KoenigEmailEditor for the email editor path instead of KoenigComposableEditor. The package public exports were updated to include KoenigEmailEditor and remove ListPlugin, ReplacementStringsPlugin, and EMAIL_TRANSFORMERS. Email node definitions were changed to remove AsideNode from EMAIL_NODES. An e2e test (email-editor.test.js) was adjusted so the horizontal rule shortcut triggers on Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fdfc19c to
3ff352e
Compare
cmraible
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@troyciesco this is ready for review!
Since we're opting to not include the slash menu, I didn't think it made sense to keep the button, callout and aside nodes since there's no way to add them at the moment.
no refs
This PR creates a new KoenigEmailEditor component. For now, having this component serves two purposes:
EMAIL_NODESNote: I also opted to remove the
AsideNode— without the slash card menu, it doesn't make sense to include since there's no way to add them.