Skip to content

Conversation

@9larsons
Copy link
Contributor

@9larsons 9larsons commented Jan 13, 2026

no refs

This PR creates a new KoenigEmailEditor component. For now, having this component serves two purposes:

  • document how the email editor is expected to be used (e.g. which plugins are required, given the EMAIL_NODES
  • cleans up the code in the Demo App a bit

Note: I also opted to remove the AsideNode — without the slash card menu, it doesn't make sense to include since there's no way to add them.

@9larsons 9larsons requested a review from troyciesco January 13, 2026 20:55
@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Walkthrough

Introduces a new KoenigEmailEditor React component (wraps KoenigComposableEditor with specific config and plugins) and adds it to the package public API. DemoApp.jsx now uses KoenigEmailEditor for the email editor path instead of KoenigComposableEditor. The package public exports were updated to include KoenigEmailEditor and remove ListPlugin, ReplacementStringsPlugin, and EMAIL_TRANSFORMERS. Email node definitions were changed to remove AsideNode from EMAIL_NODES. An e2e test (email-editor.test.js) was adjusted so the horizontal rule shortcut triggers on --- (no trailing space).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Created email editor component' accurately describes the main change: introducing a new KoenigEmailEditor component as a reusable email editor with a fixed plugin set.
Description check ✅ Passed The pull request description accurately describes the creation of KoenigEmailEditor component and explains its purposes: documenting email editor usage and cleaning up the Demo App code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons changed the title Added slash menu and cards to email editor Created email editor component, added slash menu Jan 13, 2026
@cmraible cmraible force-pushed the email-add-slash-menu branch from fdfc19c to 3ff352e Compare January 14, 2026 22:26
Copy link
Contributor

@cmraible cmraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troyciesco this is ready for review!

Since we're opting to not include the slash menu, I didn't think it made sense to keep the button, callout and aside nodes since there's no way to add them at the moment.

@cmraible cmraible changed the title Created email editor component, added slash menu Created email editor component Jan 14, 2026
@cmraible cmraible merged commit c1459a4 into main Jan 15, 2026
3 checks passed
@cmraible cmraible deleted the email-add-slash-menu branch January 15, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants