Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary flag for future version #248

Merged
merged 5 commits into from
Sep 3, 2019

Conversation

naz
Copy link
Contributor

@naz naz commented Sep 2, 2019

refs #144

Adds the ability to run checks against upcoming Ghost v3.0 themes.

Changes:

  • --canary flag for the CLI
  • canary option for checkTheme API
  • empty set of rules for v3 (canary) - all rules are the same as in v2 at this point
  • tests

Discuss:

  • wording for canary option current output:
    -c, --canary Check theme for upcoming version compatibility, instead of 2.0 [boolean]
  • any other "bare minimum" changes?

@naz naz merged commit f0aa341 into TryGhost:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant