Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added rule in canary set for ghost-api=v0.1 detection #258

Merged
merged 3 commits into from
Sep 17, 2019
Merged

✨ Added rule in canary set for ghost-api=v0.1 detection #258

merged 3 commits into from
Sep 17, 2019

Conversation

naz
Copy link
Contributor

@naz naz commented Sep 17, 2019 •
edited
Loading

refs #144

TODO:

  • clarify the use case. do we want to detect only v1 or any other incompatible version in ghost-api?
    • A: only detect v0.1 detection
  • change rule wording according to the decision above

@ErisDS ErisDS mentioned this pull request Sep 17, 2019
Closed
14 tasks
@naz naz changed the title ✨ Added pakcage.json "ghost-api === v1" error rule in canary set ✨ Added rule in canary set for ghost-api=v0.1 detection Sep 17, 2019
@naz naz merged commit 701467c into TryGhost:master Sep 17, 2019
@naz naz deleted the ghost-api-v1-rule branch September 17, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@naz