942 compact capacity #1004
Draft
942 compact capacity #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abelsiqueira
commented
Jan 22, 2025
abelsiqueira
commented
- [WIP] Replace accumulated_units_compact_method in src/constraints/capacity.jl
- [WIP] Don't use old profile in first expression of src/constraints/capacity.jl
- [WIP] Nothing makes sense
Benchmark ResultsBenchmark in progress... |
abelsiqueira
force-pushed
the
942-compact-capacity
branch
2 times, most recently
from
fce2fe1 to
58236c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
==========================================
+ Coverage 95.22% 95.25% +0.03%
==========================================
Files 29 29
Lines 1151 1159 +8
==========================================
+ Hits 1096 1104 +8
Misses 55 55 ☔ View full report in Codecov by Sentry. |
abelsiqueira
commented
Feb 4, 2025
| AND asset_milestone.milestone_year = expr_acc.milestone_year | ||
| GROUP BY | ||
| asset_milestone.asset, | ||
| asset_milestone.milestone_year |
There was a problem hiding this comment.
WHERE asset.type = 'storage'
abelsiqueira
commented
Feb 4, 2025
Comment on lines
+108
to
+113
| (row, acc_export_unit, acc_import_unit) in zip( | ||
| eachrow(expr_accumulated_flow_units.indices), | ||
| expr_accumulated_flow_units.expressions[:export], | ||
| expr_accumulated_flow_units.expressions[:import], | ||
| ) |
There was a problem hiding this comment.
Also filter for row.investable = flow_milestone.investable to match previous behaviour. @gnawin will check if that is still the case or has to be modified
abelsiqueira
commented
Feb 4, 2025
abelsiqueira
force-pushed
the
942-compact-capacity
branch
from
5033890 to
cafe367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.