Skip to content

⚡ Optimize InsightStore with async RwLock and O(1) storage #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tuntii wants to merge 2 commits into
base: main
Choose a base branch
from
Open

⚡ Optimize InsightStore with async RwLock and O(1) storage #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f419e22
Optimize InsightStore with async RwLock and O(1) storage
google-labs-jules[bot] Jan 31, 2026
c348dd2
Fix formatting in InsightStore
google-labs-jules[bot] Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/rustapi-extras/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ rustapi-openapi = { workspace = true }
# Async
tokio = { workspace = true }
futures-util = { workspace = true }
async-trait = { workspace = true }

# HTTP
http = { workspace = true }
Expand Down
16 changes: 8 additions & 8 deletions crates/rustapi-extras/src/insight/layer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,12 @@ impl InsightLayer {
}

/// Create dashboard response with recent insights.
fn create_dashboard_response(store: &dyn InsightStore, limit: usize) -> Response {
let insights = store.get_recent(limit);
async fn create_dashboard_response(store: &dyn InsightStore, limit: usize) -> Response {
let insights = store.get_recent(limit).await;
let body = json!({
"insights": insights,
"count": insights.len(),
"total": store.count()
"total": store.count().await
});

let body_bytes = serde_json::to_vec(&body).unwrap_or_default();
Expand All @@ -202,8 +202,8 @@ impl InsightLayer {
}

/// Create stats response.
fn create_stats_response(store: &dyn InsightStore) -> Response {
let stats = store.get_stats();
async fn create_stats_response(store: &dyn InsightStore) -> Response {
let stats = store.get_stats().await;
let body_bytes = serde_json::to_vec(&stats).unwrap_or_default();
http::Response::builder()
.status(StatusCode::OK)
Expand Down Expand Up @@ -240,13 +240,13 @@ impl MiddlewareLayer for InsightLayer {
.get("limit")
.and_then(|v| v.parse().ok())
.unwrap_or(100);
return InsightLayer::create_dashboard_response(store.as_ref(), limit);
return InsightLayer::create_dashboard_response(store.as_ref(), limit).await;
}
}

if let Some(ref stats_path) = config.stats_path {
if path == *stats_path && method == "GET" {
return InsightLayer::create_stats_response(store.as_ref());
return InsightLayer::create_stats_response(store.as_ref()).await;
}
}

Expand Down Expand Up @@ -359,7 +359,7 @@ impl MiddlewareLayer for InsightLayer {
}

// Store the insight
store.store(insight);
store.store(insight).await;

// Reconstruct response
http::Response::from_parts(resp_parts, ResponseBody::Full(Full::new(resp_body_bytes)))
Expand Down
Loading
Loading