Correct the 'continue' button functionality #70
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without having the 'steps' value available in the template, there's nothing to copy when building the rundown, hence the 'continue' button does not function properly.
…lity-for-multi-steps Provide 'steps' value to template definition
|
Hmmmm. Seems there's more to it - 'saving' the template (eg: after configuring the server value) seems to be discarding the 'steps' value? |
Particularly when editing the template. Previously, would discard the steps value
|
@TuomoKu , please take a look. Seems that this makes the 'steps' value be saved now, across edits of the project templates (eg: setting the casparCG player target) and this allows the 'continue' button to behave like it should during playout too. I may have gone a bit further than strictly needed, but at least it's working for me locally. Have not tried saving and importing via CSV file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the 'steps' value is not being defined within the template definition, and so it's not available for inclusion in the playout/rundown item, where it doesn't treat the 'continue' button properly.
This one line change fixes that issue.
Users will need to re-import the template and re-build the playout/rundown items, but at least, from that point on, the 'continue' button will work like it should, from what my testing shows.