-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geodesic Convolution Buffers #33
Open
mclaeysb
wants to merge
42
commits into
Turfjs:master
Choose a base branch
from
mclaeysb:geodesicconvolution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+969
−222
Open
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
2e8d9d4
point buffer implemented
morganherlocker 33b4c02
add fixtures
morganherlocker dff0c3d
multipoint buffers
morganherlocker 08b5023
line buffer test
morganherlocker 685a2e9
segment offset and caps implemented
morganherlocker 4ddb2d5
geodesic linestring buffer FC
morganherlocker 0f72899
multiline string support
morganherlocker 41833ff
linestring buffer line made
mclaeysb 2b8d30c
cleanup
mclaeysb 076506a
arc at fixed bearings
mclaeysb bd4d459
polygon offset implemented
mclaeysb d258dfe
line buffer return polygon, polygon buffer with or without rings retu…
mclaeysb e45a8aa
removed old turf featurecollection
mclaeysb b13b9c8
lineBuffer for closed line fix
mclaeysb 6cf9427
all offsets are now polygon coordinates
mclaeysb b0dc332
brackets fix and lineOffset fix fix
mclaeysb 78432fe
commented winding function
mclaeysb a5bacab
added rewind function
mclaeysb 3a0199f
automatically rewind polygons
mclaeysb 8a506c9
re-randomize arc points, remove duplicate vertices first
mclaeysb 99a1f35
added test
mclaeysb 723b692
strip simplepolygon features
mclaeysb a07f2e7
add package
mclaeysb 72fb68a
removed old fixtures
mclaeysb 8eb2573
moved test.js and fixtures to tests dir
mclaeysb 5b5d4f8
renamed tests to test
mclaeysb f68be48
basic benchmarks comparing this branch to master which uses jsts
mclaeysb 095be64
updated package with correct test ref and bench devDep
mclaeysb 77f4f96
renamed test fixtures
mclaeysb f426516
fixed equal arrays and modulo function: no longer extending built-in …
mclaeysb 20f0eb8
single simplepolygon call in offsetToBuffer
mclaeysb f75aee9
allow FeatureCollection input
mclaeysb 5c5ac1b
small tweaks
mclaeysb 92ef49b
added test that buffers circle with buffer radius equal to circle radius
mclaeysb bbdb86f
removed test/fixtures/out/*
mclaeysb a147571
Fix neglecting of holes caused by f75aee9dd5d70f310ee8289147a43747d71…
mclaeysb 6eebbf3
fix winding function
mclaeysb 60f5ad1
ignore extra fixtures and their test
mclaeysb 3350d07
entab
mclaeysb 173433a
Always measure bearings from point where arc is made
mclaeysb 81756a3
fix to make shortcut arc for reflex angles pass through point, fully …
mclaeysb e0b23e9
simplify linestrings and polygons before buffering > speedup
mclaeysb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
linestring buffer line made
commit 41833ff137c48baabb943b4ad4f57b1d1f81b469
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the JavaScript norms currently, extending built-in objects can be dangerous, since the extensions may break other code or native behavior. Could this be implemented instead as a function that takes two arrays, and the same with the
mod
extension?