Convert tests to Typescript, change require to import, and add named exports to modules #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d export as well as the default.
…angle as a named export as well as the default.
…area as a named export as well as the default.
…JS and TS test files for a while.
…ing named exports as well as the default export for modules: bbox bboxCliip bboxPolygon bearing bezierSpline booleanClockwise booleanConcave booleanContains booleanCrosses booleanDisjoint booleanEqual booleanIntersect booleanOverlap booleanParallel booleanPointInPolygon booleanPointOnLine booleanTouches booleanValid booleanWithin
…ining Typescript modules. Also adding named exports in addition to the default export for those same modules.
…to do - waiting for PR Turfjs#2543 to merge first to avoid conflicts.
… more Typescript modules (postponed until recent PRs merged). Also adding named exports in addition to the default export for those same modules.
…address probably fixed by a previous typescript upgrade. Removing redundant es5 checking script that hasn't been used for a while as well.
mfedderly
reviewed
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting all bench.js and test.js tests over to Typescript. In most cases this involved only renaming and converting require() to import(). There are still a lot of type warnings highlighted in IDEs, though they don't affect running the tests or the main build. Fixing all these type errors at once would be a mammoth task, so better to update as we go.
Replaced require() with import() in almost all cases within the module codespace. There are a few requires() left in utility scripts which can be addressed in a subsequent PR.
Added named exports for all modules. Eventually(?) default exports should be a thing of the past so laying the groundwork for that.
Both the import() and named exports work is in preparation for looking at rejigging the ESM / CJS approach used by the project.
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.