-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build housekeeping for December #2760
Conversation
… and lerna. Removed MRL rule for rollup version as we only use it in one package.
…uggested it might be a migrated config file issue, so refactored problematic section.
This probably isn't going to pass CI until we drop building on node 16 - eslint/eslint#18851 (comment) |
Made a meal of this in my fork. Will start again. |
There was a conflict between eslint and the node 16 build. Now that we've dropped 16 from CI these changes pass. Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this looks okay to me. You also eradicated 'ts-node' as a dev dependency from the top level package.json, assumedly its behavior is replaced with tsx
?
I don't know if the monorepolint piece has been superseded by some other actions/library? i.e. is there any programmatic enforcement of consistency between packages?
Thanks for that. Yes, I'm going to guess we left ts-node in to be safe when revamping the build last year. Couldn't find any remaining references to it now though.
On the whole monorepolint still runs - haven't changed that. All I removed was a rule that verified the rollup version in a single package. The rule wasn't adding any value except making someone update the version in two places should they upgrade rollup. MRL is still making sure we use the same version of typescript, etc in all packages. |
Doing chores 🧹