Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build housekeeping for December #2760

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

smallsaucepan
Copy link
Member

Doing chores 🧹

  • Updated build dependencies: tape, tsx, tsup, tslib, babel, rollup, monorepolint, and eslint.
  • Removed a monorepolint rule that wasn't adding much value. Enforcing rollup version in only one package.
  • eslint largely migrated automatically. Had to broaden some rule disabling for types.ts and test.ts. Unsure though if that was a config migration issue or eslint getting harder to please in its old age.

@smallsaucepan
Copy link
Member Author

This probably isn't going to pass CI until we drop building on node 16 - eslint/eslint#18851 (comment)

@smallsaucepan smallsaucepan marked this pull request as draft December 4, 2024 06:27
@smallsaucepan
Copy link
Member Author

Made a meal of this in my fork. Will start again.

@smallsaucepan smallsaucepan reopened this Dec 5, 2024
@smallsaucepan smallsaucepan marked this pull request as ready for review December 5, 2024 01:01
@smallsaucepan
Copy link
Member Author

There was a conflict between eslint and the node 16 build. Now that we've dropped 16 from CI these changes pass. Ready for review!

Copy link
Collaborator

@JamesLMilner JamesLMilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks okay to me. You also eradicated 'ts-node' as a dev dependency from the top level package.json, assumedly its behavior is replaced with tsx?

I don't know if the monorepolint piece has been superseded by some other actions/library? i.e. is there any programmatic enforcement of consistency between packages?

@smallsaucepan
Copy link
Member Author

Thanks for that. Yes, I'm going to guess we left ts-node in to be safe when revamping the build last year. Couldn't find any remaining references to it now though.

don't know if the monorepolint piece has been superseded

On the whole monorepolint still runs - haven't changed that. All I removed was a rule that verified the rollup version in a single package. The rule wasn't adding any value except making someone update the version in two places should they upgrade rollup.

MRL is still making sure we use the same version of typescript, etc in all packages.

@smallsaucepan smallsaucepan merged commit 42ad7b8 into Turfjs:master Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants