-
Notifications
You must be signed in to change notification settings - Fork 991
Develop and test as maintainers without building JS first #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
4bc86a0
6da37b9
cfc3c7d
8b9b2a4
26162d8
636eaf0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,18 +2,24 @@ | |
| "private": true, | ||
| "funding": "https://opencollective.com/turf", | ||
| "scripts": { | ||
| "build": "pnpx lerna run build", | ||
| "docs": "tsx ./scripts/generate-readmes.ts", | ||
| "escheck": "pnpm run /escheck:.*/", | ||
| "escheck:cjs": "es-check es8 packages/*/dist/cjs/index.cjs packages/turf/turf.min.js", | ||
| "escheck:esm": "es-check --module es8 packages/*/dist/esm/index.js", | ||
| "escheck:web": "es-check es5 packages/turf/turf.min.js", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lmao we're still shipping es5 turf.min.js. That should definitely get bumped way forward. |
||
| "lint": "pnpm run /lint:.*/", | ||
| "lint:docs": "documentation lint packages/turf-*/index.js", | ||
| "lint:escheck-cjs": "es-check es8 packages/*/dist/cjs/index.cjs packages/turf/turf.min.js", | ||
| "lint:escheck-esm": "es-check --module es8 packages/*/dist/esm/index.js", | ||
| "lint:escheck-web": "es-check es5 packages/turf/turf.min.js", | ||
| "lint:eslint": "eslint packages", | ||
| "lint:mrl": "mrl check", | ||
| "lint:prettier": "prettier --check .", | ||
| "preinstall": "npx only-allow pnpm", | ||
| "prepare": "husky && lerna run build", | ||
| "test": "pnpm run lint && lerna run test && lerna run --scope @turf/turf last-checks" | ||
| "prepare": "husky", | ||
| "prerelease": "pnpm run build && pnpm run rollup", | ||
| "release": "pnpm run test:release && pnpm publish -r", | ||
| "rollup": "lerna run --scope @turf/turf rollup", | ||
| "test": "pnpx lerna run test", | ||
| "test:release": "pnpm run lint && pnpm run escheck && lerna run --scope @turf/turf last-checks" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would be in favor of just keeping this all one |
||
| }, | ||
| "lint-staged": { | ||
| "package.json": [ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "composite": false | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a little surprised you can't use the default tsconfig.json for the build step as well. |
||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,24 @@ | ||
| { | ||
| "extends": "../../tsconfig.shared.json" | ||
| "extends": "../../tsconfig.shared.json", | ||
| "include": [ | ||
| "index.ts", | ||
| "lib/**/*.ts" | ||
| ], | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this can just be moved into tsconfig.shared.json like so:
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will give it a try. |
||
| "references": [ | ||
| { | ||
| "path": "../turf-bearing" | ||
| }, | ||
| { | ||
| "path": "../turf-destination" | ||
| }, | ||
| { | ||
| "path": "../turf-distance" | ||
| }, | ||
| { | ||
| "path": "../turf-helpers" | ||
| }, | ||
| { | ||
| "path": "../turf-invariant" | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { defineConfig } from "tsup"; | ||
| import { baseOptions } from "../../tsup.config"; | ||
|
|
||
| export default [ | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/cjs", | ||
| format: "cjs", | ||
| }), | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/esm", | ||
| format: "esm", | ||
| }), | ||
| ]; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "composite": false | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,30 @@ | ||
| { | ||
| "extends": "../../tsconfig.shared.json" | ||
| "extends": "../../tsconfig.shared.json", | ||
| "include": [ | ||
| "index.ts", | ||
| "lib/**/*.ts" | ||
| ], | ||
| "references": [ | ||
| { | ||
| "path": "../turf-bearing" | ||
| }, | ||
| { | ||
| "path": "../turf-helpers" | ||
| }, | ||
| { | ||
| "path": "../turf-invariant" | ||
| }, | ||
| { | ||
| "path": "../turf-rhumb-bearing" | ||
| }, | ||
| { | ||
| "path": "../turf-distance" | ||
| }, | ||
| { | ||
| "path": "../turf-sector" | ||
| }, | ||
| { | ||
| "path": "../turf-truncate" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { defineConfig } from "tsup"; | ||
| import { baseOptions } from "../../tsup.config"; | ||
|
|
||
| export default [ | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/cjs", | ||
| format: "cjs", | ||
| }), | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/esm", | ||
| format: "esm", | ||
| }), | ||
| ]; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "composite": false | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,15 @@ | ||
| { | ||
| "extends": "../../tsconfig.shared.json" | ||
| "extends": "../../tsconfig.shared.json", | ||
| "include": [ | ||
| "index.ts", | ||
| "lib/**/*.ts" | ||
| ], | ||
| "references": [ | ||
| { | ||
| "path": "../turf-helpers" | ||
| }, | ||
| { | ||
| "path": "../turf-meta" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { defineConfig } from "tsup"; | ||
| import { baseOptions } from "../../tsup.config"; | ||
|
|
||
| export default [ | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/cjs", | ||
| format: "cjs", | ||
| }), | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/esm", | ||
| format: "esm", | ||
| }), | ||
| ]; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "composite": false | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,18 @@ | ||
| { | ||
| "extends": "../../tsconfig.shared.json" | ||
| "extends": "../../tsconfig.shared.json", | ||
| "include": [ | ||
| "index.ts", | ||
| "lib/**/*.ts" | ||
| ], | ||
| "references": [ | ||
| { | ||
| "path": "../turf-helpers" | ||
| }, | ||
| { | ||
| "path": "../turf-invariant" | ||
| }, | ||
| { | ||
| "path": "../turf-bbox" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { defineConfig } from "tsup"; | ||
| import { baseOptions } from "../../tsup.config"; | ||
|
|
||
| export default [ | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/cjs", | ||
| format: "cjs", | ||
| }), | ||
| defineConfig({ | ||
| ...baseOptions, | ||
| entry: ["index.ts"], | ||
| outDir: "dist/esm", | ||
| format: "esm", | ||
| }), | ||
| ]; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "composite": false | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.