Skip to content

Conversation

PTWaade
Copy link
Contributor

@PTWaade PTWaade commented Oct 2, 2025

No description provided.

@PTWaade
Copy link
Contributor Author

PTWaade commented Oct 2, 2025

I changed the name of the differential equations file and model to explicitly state the name of the package used - this was done before I realized there already had been made a file. Feel very free to change things !

@penelopeysm
Copy link
Member

Sorry! I made the ODE file, and then didn't realise that it failed to compile, that's silly of me.

Comment on lines +15 to +16
rng = Random.default_rng()
Random.seed!(rng, 1234)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to not seed the rng, as long as AD can run on any values, it's not too important which values it runs on. There's of course nothing wrong with seeding it but it's generally best IMO to strip the model to the bare minimum needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it everywhere I could. Lux.setup seemed to require it, though. Want me to look for ways to avoid it, or is it okay?

@penelopeysm
Copy link
Member

In general if you could name the files just {PackageName}.jl I think that would be great!

@PTWaade
Copy link
Contributor Author

PTWaade commented Oct 3, 2025

In general if you could name the files just {PackageName}.jl I think that would be great!

I can do that, but I thought it would be nice to have the package name as well as the kind of model created with the package. The reason was that some packages might have different kinds of models they can be used for which may interact with the AD backends in different ways. Currently I used {PackageName}_{ModelType}.jl. Do you prefer just the package name ?

@PTWaade
Copy link
Contributor Author

PTWaade commented Oct 3, 2025

The contents of DifferentialEquations_ODE.jl is now identical to ordinary_diffeq.jl. Happy to use a different naming convention, as you prefer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants