-
Notifications
You must be signed in to change notification settings - Fork 2
added Lux, DifferentialEquations, AbstractGPs tutorials #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add external packages
I changed the name of the differential equations file and model to explicitly state the name of the package used - this was done before I realized there already had been made a file. Feel very free to change things ! |
Sorry! I made the ODE file, and then didn't realise that it failed to compile, that's silly of me. |
rng = Random.default_rng() | ||
Random.seed!(rng, 1234) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to not seed the rng, as long as AD can run on any values, it's not too important which values it runs on. There's of course nothing wrong with seeding it but it's generally best IMO to strip the model to the bare minimum needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed it everywhere I could. Lux.setup
seemed to require it, though. Want me to look for ways to avoid it, or is it okay?
In general if you could name the files just |
I can do that, but I thought it would be nice to have the package name as well as the kind of model created with the package. The reason was that some packages might have different kinds of models they can be used for which may interact with the AD backends in different ways. Currently I used {PackageName}_{ModelType}.jl. Do you prefer just the package name ? |
The contents of DifferentialEquations_ODE.jl is now identical to ordinary_diffeq.jl. Happy to use a different naming convention, as you prefer :) |
No description provided.