-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSMProblems integration #97
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 96.09% 95.60% -0.49%
==========================================
Files 8 8
Lines 410 410
==========================================
- Hits 394 392 -2
- Misses 16 18 +2 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8667027991Details
💛 - Coveralls |
This looks good to me. Happy for this to replace the previous partial PRs. Wrapping the observations in the model seems like a sensible approach for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FredericWantiez, good work! Feel free to merge this!
The two main issues I see with the current API in
SSMProblems
:AdvancedPS.isdone
Fixes: #93; Fixes: #94