Forbid PG/SMC on 1.12 #2691
Forbid PG/SMC on 1.12 #2691
Conversation
|
Turing.jl documentation for PR #2691 is available at: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
==========================================
- Coverage 87.21% 86.98% -0.23%
==========================================
Files 22 22
Lines 1431 1437 +6
==========================================
+ Hits 1248 1250 +2
- Misses 183 187 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ### Particle Filtering and Particle MCMC Samplers. | ||
| ### | ||
|
|
||
| LIBTASK_BROKEN = v"1.12.0" <= VERSION < v"1.12.2" |
There was a problem hiding this comment.
Could we also check against Pkg.develop's output, to check the Libtask version? Turing 0.40.6 might start to work if Libtask just puts out a bug fix release.
There was a problem hiding this comment.
Yeah, I am actually kind of unsure about this PR. I actually think that the correct solution is to fix the Julia compat bounds on Libtask itself. i.e. 0.9 should not declare compatibility with 1.12 until it is known to work with 1.12. That would require patching the General registry, which I don't mind doing.
There was a problem hiding this comment.
The downside of that is that the latest version of Turing won't be able to load on 1.12 at all since it requires Libtask 0.9. Which is also quite bad, argh.
There was a problem hiding this comment.
Yeah, not loading is bad. Also, you'd need to retrofix existing releases of Libtask, which could e.g. break existing environments that people already have in very surprising ways.
|
v glad to not have to do this |
2 participants
It'll error when it gets to Libtask anyway, so this is just a more useful error.