feat: Command for placing Waystones #1103 #1112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlayTheNinth
requested changes
Jan 16, 2026
| .then(argument("name", StringArgumentType.word()).executes(context -> { | ||
| final var pos = BlockPosArgument.getLoadedBlockPos(context, "pos"); | ||
| final var name = StringArgumentType.getString(context, "name"); | ||
| ServerLevel level = context.getSource().getLevel(); |
Member
There was a problem hiding this comment.
level variable should be used below if we're already creating it anyways. Currently seems to be unused?
| final var pos = BlockPosArgument.getLoadedBlockPos(context, "pos"); | ||
| final var name = StringArgumentType.getString(context, "name"); | ||
| ServerLevel level = context.getSource().getLevel(); | ||
| WaystonesAPI.placeWaystone(context.getSource().getLevel(), pos, WaystoneStyles.DEFAULT).ifPresent(waystone -> { |
Member
There was a problem hiding this comment.
Instead of always using WaystoneStyles.DEFAULT, there should be a parameter for the style to use
| .then(Commands.literal("place") | ||
| .requires(BalmCommands.requirePermission(PERMISSION_WAYSTONES_ACTIVATE)) | ||
| .then(argument("pos", BlockPosArgument.blockPos()) | ||
| .then(argument("name", StringArgumentType.word()).executes(context -> { |
Member
There was a problem hiding this comment.
.word() limits it to a single word in a name, but waystone names can have multiple words too
| })))) | ||
|
|
||
| .then(Commands.literal("place") | ||
| .requires(BalmCommands.requirePermission(PERMISSION_WAYSTONES_ACTIVATE)) |
Member
There was a problem hiding this comment.
This should use its own permission rather than reusing the /waystones activate permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.