-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow using a pull thru docker cache with the imagepolicy schedule #477
Merged
ekampf
merged 9 commits into
main
from
feature/oss-48-using-a-pull-thru-docker-cache-with-the-imagepolicy-schedule
Dec 16, 2024
Merged
feat: Allow using a pull thru docker cache with the imagepolicy schedule #477
ekampf
merged 9 commits into
main
from
feature/oss-48-using-a-pull-thru-docker-cache-with-the-imagepolicy-schedule
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-with-the-imagepolicy-schedule
Pull Request Test Coverage Report for Build 12262932885Details
💛 - Coveralls |
…e-with-the-imagepolicy-schedule
…e-with-the-imagepolicy-schedule
liorr
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTM
…e-with-the-imagepolicy-schedule
…e-with-the-imagepolicy-schedule
ekampf
deleted the
feature/oss-48-using-a-pull-thru-docker-cache-with-the-imagepolicy-schedule
branch
December 16, 2024 17:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Tickets & Documents
Changes
Changes how
DockerhubVersionPolicyProvider
(used to fetch latest tag from dockerhub) behaves - when looking for new tags we always check the official twingate repo (twingate/connector
) and we use therepository
value from the CRD when referncing it in the pod.So for example given this connector yaml:
The code will query
twingate/connector
on dockerhub to get the latest tags and then when creating the pod set the image to bemy-private-repo/twingate-connector:<latest tag from dockerhub>