-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable Extra Env in Chart #490
Conversation
Pull Request Test Coverage Report for Build 12360249215Details
💛 - Coveralls |
@3schwartz yeah missed that too... |
@ekampf Done One of the integration tests is failing with the error remote_network_id missing, but I’m not sure why my changes would cause this 🤔 The chart is currently referencing the latest image. Once this PR is merged, will both the new chart and the updated image be available with the changes from the prior PR, or is a release action required? |
@@ -70,6 +70,10 @@ spec: | |||
- name: TWINGATE_REMOTE_NETWORK_NAME | |||
value: {{ .Values.twingateOperator.remoteNetworkName }} | |||
{{- end }} | |||
{{- range $key, $value := .Values.extraEnvVars }} | |||
- name: {{ $key }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to do that or just keep the k8s structure (name, value) and do something like {{- toYaml .Values.extraEnvVars | nindent 8 }}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking at whats common in other charts and it seems most do something like:
## extraEnvVars:
## - name: FOO
## value: "bar"
@3schwartz closing this in favor of #491 |
Related Tickets & Documents
In PR #487, support was added to provide additional environment variables to the operator.
However, it is currently not possible to specify these variables via the Helm Chart.
Changes
This PR enables the ability to provide extra environment variables to the operator from the Helm Chart.