MacOS: Install ispc by downloading **versioned** release from GitHub
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`brew` keeps horribly breaking, and a `brew install ispc` after a
`brew upgrade` takes an insulting 13 minutes to also update all kinds
of unrelated "formulae" that are irrelevant to the request to simply
upgrade `ispc` (and direct dependencies). And it doesn't even allow us
to pin the version to match the Linux and Windows jobs.
This is simply solved by mimicking the Linux/Windows install process, by
downloading the latest versioned `ispc` binary from GitHub, extracting
it, and passing the path to `GITHUB_PATH`.
Also clean up some inconsistencies in env var resolving, to all resolve
them inside the shell script (via `$var` on UNIX and `$env:var` on
Windows) as `${{ env.var }}` doesn't work in every context (i.e. to get
to `GITHUB_PATH`).
MarijnS95
force-pushed
the
mac-download-instead-of-brew
branch
from
f861e90 to
80a00af
Compare
|
Downloading it directly on macOS instead of brew is great, thanks @MarijnS95 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brewkeeps horribly breaking, and abrew install ispcafter abrew upgradetakes an insulting 13 minutes to also update all kinds of unrelated "formulae" that are irrelevant to the request to simply upgradeispc(and direct dependencies). And it doesn't even allow us to pin the version to match the Linux and Windows jobs.This is simply solved by mimicking the Linux/Windows install process, by downloading the latest versioned
ispcbinary from GitHub, extracting it, and passing the path toGITHUB_PATH.Also clean up some inconsistencies in env var resolving, to all resolve them inside the shell script (via
$varon UNIX and$env:varon Windows) as${{ env.var }}doesn't work in every context (i.e. to get toGITHUB_PATH).