TXN-1540: Custom Provider documentation #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robdmoore, in this pull request I'm adding documentation for the Custom provider. I would greatly appreciate it if you could take a look when you have a chance. Thank you! |
|
I also fixed a few minor TypeScript errors that VS Code was complaining about (not sure why they evade |
drichar
force-pushed
the
txn-1540-update-readme-to-include-documentation-for-custom-provider
branch
from
e7b21cb to
89dbeaa
Compare
drichar
deleted the
txn-1540-update-readme-to-include-documentation-for-custom-provider
branch
|
Looks good! Thanks, and thanks for the shoutout on twitter. Only suggestion might be to link to the custom provider in xgov as a more robust example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the README to include a description of the Custom provider. It includes a general example and a link to the TestManualProvider in the Storybook example.
Checklist