add Lute as Provider #129
Merged
add Lute as Provider #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichar
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Thank you for the PR, @acfunk! And thank you for making the necessary library updates to get this working with Jest. Everything looks great.
I made one minor change request to update the getDynamicLuteConnect function in the example to an arrow function to match the others in the example. Also not sure about the https://github.com/microsoft/vscode-eslint settings change... lmk what that's about and why you're changing it.
After that I'll approve what's here! We'll get Lute support into the next release.
|
It should be ready to go. Thanks for your guidance on this @drichar! |
drichar
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lute is a Ledger-only Algorand web wallet. This PR adds Lute as a provider.
Checklist