Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kibisis): replace global object with window #139

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix(kibisis): replace global object with window #139

merged 1 commit into from
Feb 6, 2024

Conversation

kieranroneill
Copy link
Contributor

@kieranroneill kieranroneill commented Feb 6, 2024

Description

Please explain the changes you made here

global was used to access the Web Crypto API to generate a UUID, but this only works in a Node.js environment and therefore throws a TypeError when run in a browser environment.

This fix changes the global reference to window to correctly reference the Web Crypto API in a browser environment.

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@drichar drichar merged commit e686564 into TxnLab:main Feb 6, 2024
1 check passed
@kieranroneill kieranroneill deleted the fix/kibisis/global-not-defined-error branch February 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants