feat: add ability to throw connection errors #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichar
requested changes
Mar 13, 2024
There was a problem hiding this comment.
This looks good! I was just talking with someone in our Discord about handling errors thrown by signTransactions in the consuming app... this would allow for doing the same with connection errors (while being non-breaking).
Just two minor change requests (linting/formatting), then this is good to go!
Thank you for the PR! And sorry about the delay reviewing it.
PhearZero
force-pushed
the
feat/throws-error-flag
branch
from
22f400b to
3cb35ca
Compare
drichar
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
throwsparameter toconnectin order to react to connection errorsChecklist