fix(wallets): prevent WalletConnect v1 session data collision #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip `reconnectSession` for inactive Pera/Defly wallets since wallet state is already managed by use-wallet. This prevents a bug where both wallets share the same WalletConnect v1 storage key, causing the inactive wallet to overwrite the active wallet's connected accounts on session resume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where inactive WalletConnect v1 wallets (Pera/Defly) would overwrite the active wallet's connected accounts during session resume. The fix skips the
reconnectSessioncall for inactive wallets since the library already handles wallet state persistence.Details
reconnectSessionfor inactive Pera/Defly wallets