Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-9464] New encoding URL function #80

Merged
merged 13 commits into from
Aug 7, 2023
Merged

[TT-9464] New encoding URL function #80

merged 13 commits into from
Aug 7, 2023

Conversation

mativm02
Copy link
Contributor

@mativm02 mativm02 commented Jul 27, 2023 •
edited
Loading

Description

Now we're encoding the URL in mongo-go driver just to keep compatibility with mgo

After some manual testing, I can conclude the following:
Special characters allowed by both mgo and mongo-go:
“-”
“}”
“.”
“=”
“#”
“[]”

Special characters allowed by mgo but not mongo-go:
“/”
“:”

Special character disallowed by both drivers:
“?”
“@”

Related Issue

https://tyktech.atlassian.net/jira/software/c/projects/TT/boards/42?modal=detail&selectedIssue=TT-9464

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • I have reviewed the guidelines for contributing to this repository.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...

@mativm02 mativm02 marked this pull request as ready for review July 31, 2023 12:10
@mativm02 mativm02 changed the title [WIP] New encoding URL function [TT-9464] New encoding URL function Aug 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.0% 93.0% Coverage
0.0% 0.0% Duplication

@mativm02 mativm02 merged commit 0871150 into main Aug 7, 2023
7 checks passed
@mativm02 mativm02 deleted the TT-9464-2 branch August 7, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbuchaillot tbuchaillot tbuchaillot approved these changes

@sredxny sredxny Awaiting requested review from sredxny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mativm02 @tbuchaillot