Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging to release-4-lts: [TT-9196] fix dashboard client timeout (#5176) #5229

Conversation

buger
Copy link
Member

@buger buger commented Jun 27, 2023

TT-9196 fix dashboard client timeout (#5176)

Dashboard client on the gateway side has a hardcoded 30 seconds and
times out when dealing with larger amounts of APIs and Policies. Instead
of the 30 seconds we can parametrize that value and allow the customer
to determine the amount they are comfortable with.

Description

Related Issue

https://tyktech.atlassian.net/browse/TT-9196

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why

<!-- Provide a general summary of your changes in the Title above -->
Dashboard client on the gateway side has a hardcoded 30 seconds and
times out when dealing with larger amounts of APIs and Policies. Instead
of the 30 seconds we can parametrize that value and allow the customer
to determine the amount they are comfortable with.

## Description

<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

https://tyktech.atlassian.net/browse/TT-9196

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why

(cherry picked from commit d73dfa0)
@buger buger enabled auto-merge (squash) June 27, 2023 08:23
@buger buger merged commit a3c9572 into release-4-lts Jun 27, 2023
2 of 5 checks passed
@buger buger deleted the merge/release-4-lts/d73dfa01dd5100a6584ae415cef0d6702b75b3cd branch June 27, 2023 08:25
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jun 27, 2023

API tests result: success
Branch used: refs/pull/5229/merge
Commit:
Triggered by: pull_request (@buger)
Execution page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants