Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-13122] docker image push on 1.22-bullseye #6548

Closed
wants to merge 0 commits into from

Conversation

jeffy-mathew
Copy link
Contributor

@jeffy-mathew jeffy-mathew commented Sep 18, 2024

User description

Description

Related Issue

https://tyktech.atlassian.net/browse/TT-13122

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

PR Type

enhancement, configuration changes


Description

  • Updated the GitHub Actions workflow to build a multiarch Docker image using the '1.22-bullseye' version instead of '1.21-bullseye'.
  • This change ensures that the Docker image is built with the latest specified version, aligning with the new requirements.

Changes walkthrough 📝

Relevant files
Configuration changes
release.yml
Update Docker image build version to 1.22-bullseye             

.github/workflows/release.yml

  • Updated the condition for building a multiarch image.
  • Changed the version from '1.21-bullseye' to '1.22-bullseye'.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @jeffy-mathew jeffy-mathew requested a review from a team as a code owner September 18, 2024 14:11
    @jeffy-mathew jeffy-mathew changed the base branch from master to release-5.6.0 September 18, 2024 14:11
    Copy link
    Contributor

    Swagger Changes

         _        __  __
       _| |_   _ / _|/ _|  between swagger-prev.yml
     / _' | | | | |_| |_       and swagger-current.yml
     \__,_|\__, |_| |_|   returned no differences
    | (_| | |_| |  _|  _|

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    API Changes

    no api changes detected

    Copy link
    Contributor

    github-actions bot commented Sep 18, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Use a regex in the condition to accommodate future versions

    Consider using a more inclusive condition to allow for future versions without
    needing to update the workflow. You can use a regular expression to match any
    version that starts with '1.' and ends with '-bullseye'.

    .github/workflows/release.yml [174]

    -if: ${{ matrix.golang_cross == '1.22-bullseye' }}
    +if: ${{ matrix.golang_cross ==~ '^1.*-bullseye$' }}
     
    Suggestion importance[1-10]: 8

    Why: The suggestion to use a regex allows for greater flexibility and future-proofing of the workflow by accommodating future versions without needing manual updates, which is a significant enhancement. The existing code is correctly identified, and the improved code reflects the suggestion accurately. However, the change is not critical, hence not a perfect score.

    8

    Copy link

    sonarcloud bot commented Sep 18, 2024

    @titpetric titpetric changed the title docker image push on 1.22-bullseye [TT-13122] docker image push on 1.22-bullseye Sep 18, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants