-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging to release-5.5: [TT-13087] Adjust example gateway config, to have match preficing explicit by default (#6564) #6569
Merging to release-5.5: [TT-13087] Adjust example gateway config, to have match preficing explicit by default (#6564) #6569
Conversation
…licit by default (#6564) ### **User description** ## Description TT-13087 Adjust example gateway config, to have match preficing explicit by default ## Motivation and Context Would be advised that Gateway users, would have by default explicit path matching settings enabled by default, as the wildcard behaviour of the path matching, can be challenging at times to configure properly. ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [x] I ensured that the documentation is up to date - [x] I explained why this PR updates go.mod in detail with reasoning why it's required - [x] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** enhancement, configuration changes ___ ### **Description** - Added new configuration options in `tyk.conf.example` to enable strict routing and explicit path matching by default. - The changes aim to improve the default behavior for gateway users by making path matching settings explicit. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>tyk.conf.example</strong><dd><code>Add explicit path matching options to example gateway config</code></dd></summary> <hr> tyk.conf.example <li>Added <code>http_server_options</code> section.<br> <li> Enabled <code>enable_strict_routes</code>.<br> <li> Enabled <code>enable_path_prefix_matching</code>.<br> <li> Enabled <code>enable_path_suffix_matching</code>. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6564/files#diff-a6736b4b3cda1ee503675d7b725f6138f4eb83d7145f3afecf6087d219f2b23a">+5/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information (cherry picked from commit d98cc03)
API Changes no api changes detected |
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Quality Gate passedIssues Measures |
User description
TT-13087 Adjust example gateway config, to have match preficing explicit by default (#6564)
User description
Description
TT-13087 Adjust example gateway config, to have match preficing explicit
by default
Motivation and Context
Would be advised that Gateway users, would have by default explicit path
matching settings enabled by default, as the wildcard behaviour of the
path matching, can be challenging at times to configure properly.
How This Has Been Tested
Types of changes
functionality to change)
coverage to functionality)
Checklist
why it's required
explained why
PR Type
enhancement, configuration changes
Description
tyk.conf.example
to enable strictrouting and explicit path matching by default.
making path matching settings explicit.
Changes walkthrough 📝
tyk.conf.example
Add explicit path matching options to example gateway config
tyk.conf.example
http_server_options
section.enable_strict_routes
.enable_path_prefix_matching
.enable_path_suffix_matching
.PR Type
enhancement, configuration changes
Description
enable_strict_routes
,enable_path_prefix_matching
, andenable_path_suffix_matching
settings to improve route handling.Changes walkthrough 📝
tyk.conf.example
Add explicit path matching options to example gateway config
tyk.conf.example
http_server_options
.enable_strict_routes
for strict route handling.enable_path_prefix_matching
for explicit path prefix matching.enable_path_suffix_matching
for explicit path suffix matching.