Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSE-394 release-5-lts] Fix test code base for Tyk-Analytics PRs #6582

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

konrad-sol
Copy link
Contributor

A PR has been created by to address the PRs on tyk-analytics checking out the wrong base (base branch) when working on a pull-request over the tyk-analytics repo.In this case developers would want to checkout the HEAD of the branch instead of the BASE so they can have their new tests in place for the PR.PR being worked out under QA board: TykTechnologies/gromit#346

@konrad-sol konrad-sol requested a review from a team as a code owner September 24, 2024 07:25
@konrad-sol konrad-sol enabled auto-merge (squash) September 24, 2024 07:25
Copy link
Contributor

API Changes

no api changes detected

@buger buger force-pushed the releng/release-5-lts branch 3 times, most recently from 5574af8 to d3cd222 Compare October 1, 2024 06:30
Copy link
Contributor

github-actions bot commented Oct 1, 2024

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

@buger buger force-pushed the releng/release-5-lts branch 3 times, most recently from 7885381 to 65a3551 Compare October 1, 2024 11:10
Copy link
Contributor

github-actions bot commented Oct 1, 2024

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

@buger buger force-pushed the releng/release-5-lts branch 4 times, most recently from ab797e7 to 7bf06c6 Compare October 1, 2024 16:36
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
56.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@alephnull alephnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@konrad-sol konrad-sol merged commit 422e4ed into release-5-lts Oct 2, 2024
33 of 35 checks passed
@konrad-sol konrad-sol deleted the releng/release-5-lts branch October 2, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants