Updated to monaco-vscode-api 1.79.2 / monaco-editor 0.39.0

[kaisalmen]

Still WIP.
Even without adding new services, I see this error now:

Is this already fixed by this: CodinGame/monaco-vscode-api#128 ?

[kaisalmen]

@CGNonofr I guess it makes sense to release a next version with every big monaco-vscode-api PR and test it here beforehand as well.

[CGNonofr]

Is this already fixed by this: CodinGame/monaco-vscode-api#128 ?

Probably not! I'll have a look

[CGNonofr]

Ok it's fixed in CodinGame/monaco-vscode-api@824f51b

[kaisalmen]

Ok it's fixed in CodinGame/monaco-vscode-api@824f51b

@CGNonofr thank you, I will test it later ..

[kaisalmen]

First problem is gone. This error shows up if I add the markers service. Does it depend on something else? Here I added everything, but the new terminal service. Does this even make sense without using the view service? If I don't configure the markers and terminal service there is no error.

[kaisalmen]

@CGNonofr FYI I just copied over your TerminalBackend from the demo and then I get two errors (from markers and terminal):

That's just a local test. The code is not pushed up.

[CGNonofr]

First problem is gone. This error shows up if I add the markers service. Does it depend on something else? n't configure the markers and terminal service there is no error.

I guess it won't work without the view services, but the markers service override just adds the Problems view so it has no point anyway

Here I added everything, but the new terminal service. Does this even make sense without using the view service?

No. The marker service override doesn't add any service for the moment, it just register the marker view

FYI I just copied over your TerminalBackend from the demo and then I get two errors (from markers and terminal):

THAT is weird, I'll have a look

[CGNonofr]

It's fixed and published as @codingame/monaco-vscode-api@1.79.3-next.3

[kaisalmen]

@CGNonofr markers service with views service enabled, but not "renderPanelPart" set. I guess this is expected:

[CGNonofr]

@CGNonofr markers service with views service enabled, but not "renderPanelPart" set. I guess this is expected:

Is it an issue? what would you want?

[kaisalmen]

I wanted to know if that is your expectation, too. I think that this is the correct behaviour.

[kaisalmen]

If markers is configured without views enabled this now throws an error

[CGNonofr]

Maybe we can improve the doc but importing markers without the views make no sense

[kaisalmen]

Maybe we can improve the doc but importing markers without the views make no sense

Yes, docs should be updated. I added this code: https://github.com/TypeFox/monaco-languageclient/blob/mva-1.79.2/packages/client/src/monaco-vscode-api-services.ts#L171-L191 to flag / produce errors on bad configuration.

[kaisalmen]

@CGNonofr 1.79.3-next.4 works fine. 👍
I can confirm that when I add a panel and use markers with views service there are no more errors.

[kaisalmen]

@CGNonofr are you ok with changes. I will update the version to 6.2.0 after merge.

[kaisalmen]

Oh it was still a draft. Version change is in here already.

[kaisalmen]

@CGNonofr you raised a thumb, but you have to approve. Thank you

[kaisalmen]

I went ahead. Want to publish the release. 😊

[CGNonofr]

It was still a draft at that time :)

[kaisalmen]

Sorry, I overlooked that 🙂