Langium binding and more #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JohannesMeierSE
commented
Oct 14, 2024
JohannesMeierSE
commented
- added first version of a Typir binding for Langium
- integrated type creation into a service
- added listeners for added/removed types/edges
- fixed bugs
- handle the removal of types and their inference rules
- extended validation API
- validation for unique function and class declarations
…r infrastructure, simplified services+modules for DI
…rastructure, handle deleted Langium documents, getOrCreate user types in OX and LOX
… register inference rules also for getOrCreateX, fixed bug in OX application
insafuhrmann
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Thank you very much for your work on this @JohannesMeierSE. This looks good to me, I have added a few detail remarks. There are a few things to check on at a later time as we discussed in our Typir meeting today (e.g. the suggestions by Markus constructor use, initializeWorkspace, eagerload etc.).
|
Thanks a lot for your helpful review @insafuhrmann! I pushed the changes and will merge it on
You are completely right, some fine-tuning is still required, which I will do in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.