Add mechanism to extend the JSX namespace for custom elements (and attributes) #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SacDeNoeuds
commented
Dec 9, 2024
Comment on lines
+116
to
+117
| namespace JSX { | ||
| namespace JSX { |
There was a problem hiding this comment.
This is not a typo but the result of a test
|
Thanks! I squashed locally, so apparently GitHub didn't realized I merged... 993c0f5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
I would like to start by thanking you for this amazing package 🙏. To be honest, so far I have always avoided using TypeDoc only because I never found a theme that I liked, so I figured I'd build one!
And here is ➡️ https://github.com/SacDeNoeuds/typedoc-unhoax-theme/
I tried covering as much stuff as I could, if you find anything that needs updating I'm all ears 😊
Anyway, in the process of making the theme, I wanted to use the (quite new) popover API and figured I could not extend the JSX namespace, hence this PR.
The content:
JsxHtmlGlobalPropsinterface underJSX.IntrinsicAttributes.JsxHtmlGlobalPropsinterface.I hope it helps.