-
Notifications
You must be signed in to change notification settings - Fork 586
Update translation: zh-CN (Simplified Chinese) #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
It looks like you added some personal annotations rather than strictly following the original text. Anyway, before discussing the content, I have a couple of questions:
|
|
I will provide some review suggestions later, for now, I'm seeing:
some from your example:
… also, as long as you're still using “喔唷,Aegisub娘崩溃啦!”, I feel it's still not very proper to remove the contribution remark from Vmoe Fansub. Overall still a solid job, but it could use some more polish. Would be grateful if you could later respond to review comments. |
我的英语水平一坨,可喜可贺的是英语水平一坨翻译的句子能让新手一眼看懂,而不是原来某些 动名词都分不清的翻译
和
一句话用两句都表意不清的废话文学
并且我能找到的、且需要翻译的功能,我都使用了一遍,原文本身就含有大量的表意不清,须按照实际含义翻译,否则新手根本看不懂 |
我是说你的翻译用的是旧的(3.2 版本),而不是 3.4 修订过的 我最后那句话没有任何批评的意思,只是说你的 PR 我差点没看懂 |
I did not delete any info about Vmoe, I even kept the header info intact in the comments for possible future restoration About original text, I think there are many unreasonable aspects: If you open the option The original text have a large number of similar thing (bugs), so that's why feature based translation is needed instead of original text based translation |
几乎无法直接合并,用 pot 重新生成 po 后,文本对比功能也废了,所以我手动跟 3.4 的 po 对比了一个多小时…… 例如 关于 而 |
So your understanding of what the toggle is doing is a bit off. Please try:
(I'll supplement a video later) Please do not assume the source language is "faulty" before you can confidently support your acclaim with proper understanding of the functionality. |
或许你可以参考 git 的提交。 但 3.4 版本大部分新翻译都被改回去了,这部分还是有不少改进的,请见 #210。
在 编辑 > 撤销,还有一处 combining 也是在这,原本翻译是错的。 |
|
Translating "recombine" as "合并" may cause confusion with "join," as their behaviors are different. |
Now I understand your means, thank you for your reminder Firstly, I had never noticed before that it treats tags as empty Secondly, I know before that its function is to skip whitespace, A few months ago, I translated it as |
等我睡一觉后再核对一遍😭 已经感觉快4了 |
我想起来了,我可以先把 3.4 的 po 生成新 po,然后再做文本比较 唉woc😭白白浪费一两个小时 |
|
Already fully cmp the 3.4 po I thought that could finish soon, but it still took over an hour😭 Fortunately, made many necessary modifications to the translation org po + pot -> new 3.4 po |
|
Is that so? I still see some differences—were they intentional?
|
第一个 ratio 作为比值(系数)翻译,所以不写 第二个那一大段我没注意到……改了, 第三个改成 |
|
Alright, now we've finally reached the first step, which is reviewing the translation. I agree with @EL-File4138's opinion. I'll go through your translation later again. |
oborozuk1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed these for now. I think we should discuss whether some annotations are really necessary or if we should follow the original text instead.
EL-File4138
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of Change (1/3)
This review covers the first 2000 lines of only the changing part. The inherited part will be done separately.
Co-authored-by: Matrew File <elfile4138@elfile4138.moe>
|
I'm slowly getting back to Aegisub development after being busy with personal projects for a few months. What's the status of this language PR? I see some unresolved review comments, does everyone here agree this is ready to merge, or are there still disagreements? |
|
I would suggest putting it on hold if there isn't a recent plan to release a new version. I'm still consulting with a variety of zh-CN communities for feedback. |
|
I will resolve it when free |
|
我目前将 我觉得 不知大家有没有什么更好的想法 |
File saving is handled through a RAII handle class `Save`, so errors on saving result in exceptions being thrown from that class's destructor. Since TextFileWriter held the Save handle inside a std::unique_ptr (whose destructor is noexcept) this would cause a crash. Destructors that throw are a big footgun for exactly these reasons, but fixing this would require quite a big refactor. For now we can just take the Save handle out of the unique_ptr. Fixes TypesettingTools#476.
Without it, Aegisub is identified as an iOS app in System Info, rather than Apple Silicon
This is only intended for the C++ code, not for actual Lua scripts. (In theory it's accessible from Lua, but it's a private function that could be renamed or removed at any time. Lua scripts can show warnings using aegisub.log or dialogs.) The main purpose of such warnings at the moment is deprecating utility modules. This is why it's possible to raise warnings both during initial loading (such warnings are added to the script error list and visible in the automation script list) and during execution (whether that be a macro or filter invocation or some status function like validation - such warnings just show dialogs directly).
Keep the library available in Lua for now, but show a warning when scripts try to import it. Luabins is a vendored dependency in Aegisub and is no longer maintained upstream. It is not directly used anywhere by Aegisub itself; it was only added as a convenience library for automation scripts, especially for serializing tables to save as line extradata. However, I am not aware of any automation script that actually uses it. (Scripts that do need to serialize data to extradata use the json library for this.) So, at the moment luabins causes some headaches in the build process for what seems to be no gain at all, which is why it is now being deprecated. If no users complain about desperately needing luabins for their script for the next release cycle, luabins will be removed entirely afterwards. Fixes TypesettingTools#382.
Use an ad-hoc signature unless another signature is specified via the environment variable AEGISUB_BUNDLE_SIGNATURE.
aegisublocale.cpp -- Make dialog window translatable
auto4_base.cpp -- Make warning logs translatable
auto4_lua.cpp -- Make descriptions used in the Create() function translatable
dialog_attachments.cpp -- Make file types translatable --> I also noticed that the file extraction dialog only has one file type ("Font Files"), so I added two new types: "All Supported Formats" and "Graphic Files"
dialog_automation.cpp -- Make warning log translatable
dialog_dummy_video.cpp -- Make resolution names translatable
dialog_export.cpp -- Make message boxes translatable
dialog_properties.cpp -- Make "YCbCr Matrix:" string translatable
dialog_spellchecker.cpp -- Make message boxes translatable
dialog_style_manager.cpp -- Make message boxes translatable
main.cpp -- Make message boxes translatable
preferences.cpp -- Make FFmpegSource's log levels, search bar and columns' titles of hotkey table translatable
project.cpp -- Make message boxes translatable
subs_controller.cpp -- Make "Untitled" string filename and messages translatable
subs_preview.cpp -- Make message box translatable
video_provider_manager.cpp -- Make error strings translatable
macro-2-mkfullwitdh.lua -- Make script metadata translatable
timecode.cpp -- Fix file types names video.cpp -- Fix descriptions of "video play" commands: "video/play" -> fixed grammar; "video/play/line" -> made description slightly more verbose to prevent it from fetching translation from "audio/play/line"'s STR_DISP (or STR_MENU, idk) vis_tool.cpp -- Remove suffixes from visual vector tools
The `wxDEFAULT_FRAME_STYLE` macro already includes `wxCLIP_CHILDREN`. Removing this redundant flag leaves the position, size, and style arguments matching their default values, allowing them to be omitted. https://github.com/wxWidgets/wxWidgets/blob/d6af1f50caafcbc00a38f13213fefc3a1e713f8a/include/wx/toplevel.h#L77-L85
6f7e314 made the FFMS2 log levels translatable. Translating dropdown choices in the preferences dialog worked fine for int options, but not for string options. To keep these strings translatable but not break compatibility by turning the option into an int option, make the OptionChoice function able to translate string options itself, while storing the untranslated values in the options. This is quite a lot of added code just to make one niche option translatable, but it allows turning more options into string options in the future, which behave better when better when choices are added. (On the other hand, int options behave better when choices are renamed, but either way the upshot is that choices for string options can now be translated.)
|
@0tkl 请问这个 pr 能否合并? 我之前 fork 了 arch1t3cht 的库,GitHub 不允许我从 TypesettingTools fork,我打算等这个 pr 合并后删除库重新 fork,不然我每次得手动拉取并解决冲突 |
|
你可以参考 https://github.com/orgs/community/discussions/22103#discussioncomment-14468953 把自己仓库的上游从 arch1t3cht 那里改成 TypesettingTools 这里 |
Update Simple Chinese (zh-CN) translation
msgmerge pot(this branch)->po from branch feature (arch1t3cht), manual confirmation is correct
The translations of all functional options have been tested by me to ensure accuracy
Complete the translation
(The newly added part or untranslated part)
e.g.
Open Recent->最近打开Visual Typesetting Tools Alpha->可视化绘图工具透明度Skip over whitespace->跳过空行Revise a small amount of translations to use more contemporary language
Standardize inconsistent translations throughout
Uniform punctuation usage
e.g.
热键->快捷键偏好->首选项:->: