Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hidden browsers showing up in Select window #164

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fix hidden browsers showing up in Select window #164

merged 3 commits into from
Sep 23, 2024

Conversation

ArthurMacTavish
Copy link
Contributor

So, in Hurl v0.9.0, there's an issue where the if you set a browser as hidden, it would still shows up.

image

So this PR, fixes the issue by not including the hidden browsers in the browser selector screen. Thanks.

U-C-S
U-C-S requested changes Sep 20, 2024
View reviewed changes
Copy link
Owner

@U-C-S U-C-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, didn't realize I had broken this option.

Source/Hurl.BrowserSelector/Controls/BrowserButton.xaml.cs Outdated Show resolved Hide resolved
@U-C-S U-C-S changed the title Fix the browser won't hidden problem. Fix hidden browsers showing up in Select window Sep 23, 2024
@U-C-S U-C-S merged commit df2d952 into U-C-S:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@U-C-S U-C-S U-C-S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArthurMacTavish @U-C-S