Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Repository cleanup #265

Merged
merged 23 commits into from
Aug 7, 2024
Merged

[Chore] Repository cleanup #265

merged 23 commits into from
Aug 7, 2024

Conversation

d3li0n
Copy link
Contributor

@d3li0n d3li0n commented Jul 4, 2024

Description

Cleaning up and updating READMEs in the repository.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Other (please describe)

How Has This Been Tested?

N/A

Checklist:

N/A

@d3li0n d3li0n added the documentation Improvements or additions to documentation label Jul 4, 2024
@d3li0n d3li0n self-assigned this Jul 4, 2024
@d3li0n d3li0n added the chore provides value to team rather than client. Ex. implementing continuous integration/refactoring label Jul 4, 2024
@KafkaNoNeko KafkaNoNeko linked an issue Jul 25, 2024 that may be closed by this pull request
@KafkaNoNeko
Copy link
Contributor

@d3li0n I've updated most of the READMEs except for the OMR tool (I think Fran is still working on it) and documentation ones (I'll add those to the doc branch)

Is there anything else I am missing or should this be marked ready for review now?

poetry run python -m main
```

### Running the bubble sheet generator within a container
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably not implement container steps

@KafkaNoNeko
Copy link
Contributor

@d3li0n Fran said he will add documentation for the omr tool so I am marking this as ready for review

@KafkaNoNeko KafkaNoNeko marked this pull request as ready for review August 3, 2024 05:59
Copy link
Contributor

@fperellaholfeld fperellaholfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good based on the rich diff

Copy link
Contributor

@BennettChang BennettChang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3li0n d3li0n merged commit ab00aae into development Aug 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore provides value to team rather than client. Ex. implementing continuous integration/refactoring documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Documentation fixes
4 participants