Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Website README #386

Merged
merged 2 commits into from
May 7, 2024
Merged

Update Website README #386

merged 2 commits into from
May 7, 2024

Conversation

jahn18
Copy link
Member

@jahn18 jahn18 commented May 6, 2024

Description

Made some slight updates to our README to include some new details regarding our env vars and tech stack. The existing documentation for Typescript, React, Redux, etc. is explained pretty well and there's nothing specific to the website that will require further explaination. I attached links to those.

(EDIT: Also adding Jordan as the codeowner for the website here)

Verification

Resources

@jahn18 jahn18 added the web Website team label May 6, 2024
@patrick-5546 patrick-5546 changed the title Update Documentation Update Website README May 6, 2024
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So merge in #366, and Jordan will finish CD in another PR?

@patrick-5546
Copy link
Member

So merge in #366, and Jordan will finish CD in another PR?

If that's the case, should probably create a new issue for this and resolve the PR review comments in #366

@jahn18
Copy link
Member Author

jahn18 commented May 7, 2024

So merge in #366, and Jordan will finish CD in another PR?

If that's the case, should probably create a new issue for this and resolve the PR review comments in #366

Originally I was thinking about having Jordan work off my branch, but this is a better idea. Let's do that.

I created an issue here: #387

@jahn18 jahn18 mentioned this pull request May 7, 2024
@jahn18 jahn18 merged commit 6680af5 into main May 7, 2024
10 checks passed
@jahn18 jahn18 deleted the doc-changes branch May 7, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Website team
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create docs page Reference/Web Development
2 participants