Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Adding functionality for AnaReentrantAlgorithms #1717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdhank
Copy link
Contributor

@mdhank mdhank commented Feb 17, 2025

Adding functionality for AnaReentrantAlgorithms using PythonConfig

@mdhank mdhank self-assigned this Feb 17, 2025
@mdhank
Copy link
Contributor Author

mdhank commented Feb 17, 2025

Hi @SagarA17 ,

Could you test if this works for you with AB 24.2.40? I don't have a full AnaRentrantAlgorithms setup so can't test this easily, though I've managed to make my test branch crash in the same way as in 24.2.39 (before these changes it would crash differently).

Best,
Michael

@SagarA17
Copy link
Contributor

Hi @mdhank. Thanks a lot for this change! I was able to run my tests with these changes and they worked successfully. Appreciate the prompt help! Might I suggest adding AB versions in CI up to 24.2.43 to ensure that the up to date compatibility is accurately reflected? Thanks again!

@SagarA17
Copy link
Contributor

Btw one small suggestion from my side would be to look into the AnaAlgorithm.DualUseConfig as was suggested in the MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/77352#note_9056993, since they seem to hint that the other methods will be obsoleted in due time, but perhaps this is not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants