Minor fixes/changes to logging (#46)

* Add missing arg2 to console mirror in LogEmitter * Replace open folder function with a cross-platform alternative
UCL-VR · Jan 16, 2024 · 8517be2 · 8517be2
1 parent 306ddd7
commit 8517be2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Unity/Assets/Editor/Logging/LogCollectorEditor.cs b/Unity/Assets/Editor/Logging/LogCollectorEditor.cs
@@ -69,9 +69,9 @@ public override void OnInspectorGUI()
             if (GUILayout.Button("Open Folder"))
             {
                 var path = Application.persistentDataPath;
-                path = path.Replace("/","\\");
-                System.Diagnostics.Process.Start("explorer.exe", path);
+                Debug.Log($"Opening {path} in file explorer");
+                EditorUtility.RevealInFinder(path);
             }
         }
     }
-}
+}
diff --git a/Unity/Assets/Runtime/Logging/LogEmitter.cs b/Unity/Assets/Runtime/Logging/LogEmitter.cs
@@ -127,7 +127,7 @@ public void Log<T1, T2>(string Event, T1 arg1, T2 arg2)
             }
             if (mirrorToConsole)
             {
-                Debug.Log(String.Format("{0} {1}", Event, arg1));
+                Debug.Log(String.Format("{0} {1} {2}", Event, arg1, arg2));
             }
         }