Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update contents for coding conventions #241

Merged
merged 2 commits into from
Aug 14, 2024
Merged

refactor: update contents for coding conventions #241

merged 2 commits into from
Aug 14, 2024

Conversation

Saransh-cpp
Copy link
Member

  • get rid of the weird context import and conventions.py
  • showcase ruff and pre-commit (with pre-commit.ci)

@Saransh-cpp
Copy link
Member Author

The workflow changes in #240 should make everything pass

@Saransh-cpp Saransh-cpp mentioned this pull request Aug 12, 2024
Merged
@Saransh-cpp Saransh-cpp requested a review from dpshelio August 12, 2024 14:24
dpshelio
dpshelio approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good and beautiful!

dpshelio
dpshelio requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check whether the conventions file is only used in this file.

@Saransh-cpp Saransh-cpp force-pushed the saransh/revamp-guidelines branch from 4e77204 to 689ed42 Compare August 14, 2024 13:47
dpshelio
dpshelio approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@dpshelio dpshelio merged commit 3a07da1 into main Aug 14, 2024
4 checks passed
@dpshelio dpshelio deleted the saransh/revamp-guidelines branch August 14, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpshelio dpshelio dpshelio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saransh-cpp @dpshelio