Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade eslint to v8 because of Next compatibility issues with esli… #156

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

justinsheu
Copy link

…nt v9

Fix lint errors associated with this issue vercel/next.js#64409
Support for eslint 9 seems to be coming in Next.js v15

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for cl-official ready!

Name Link
🔨 Latest commit 2cfe494
🔍 Latest deploy log https://app.netlify.com/sites/cl-official/deploys/6716007ec0b234000834ad94
😎 Deploy Preview https://deploy-preview-156--cl-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for clwebsitetest ready!

Name Link
🔨 Latest commit 2cfe494
🔍 Latest deploy log https://app.netlify.com/sites/clwebsitetest/deploys/6716007ea7c7b10008af03ba
😎 Deploy Preview https://deploy-preview-156--clwebsitetest.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@justinsheu justinsheu marked this pull request as ready for review October 21, 2024 07:26
@justinsheu justinsheu requested a review from olliepai October 21, 2024 07:27
@justinsheu
Copy link
Author

justinsheu commented Oct 21, 2024

Also added contentful env vars to clwebsitetest deployment env to fix netlify checks

Copy link
Member

@olliepai olliepai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good~

@mergify mergify bot merged commit e7a738f into new_site Oct 23, 2024
11 checks passed
Copy link

mergify bot commented Oct 23, 2024

Thanks for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants